feat(vsts): Add API-driven integration setup#113073
Open
evanpurkhiser wants to merge 1 commit intomasterfrom
Open
feat(vsts): Add API-driven integration setup#113073evanpurkhiser wants to merge 1 commit intomasterfrom
evanpurkhiser wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
Backend Test FailuresFailures on
|
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-vsts-add-api-driven-integration-setup
branch
from
041107b to
12fdf4e
Compare
Contributor
Backend Test FailuresFailures on
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 12fdf4e. Configure here.
| ).capture() as lifecycle: | ||
| oauth_data = pipeline.fetch_state("oauth_data") or {} | ||
| access_token = oauth_data.get("access_token") | ||
| user = get_user_info(access_token) |
Contributor
There was a problem hiding this comment.
Unhandled None access_token crashes get_step_data
Medium Severity
In get_step_data, oauth_data.get("access_token") can return None, which is then passed to get_user_info. That function builds an auth header "bearer None" and calls raise_for_status() on the resulting 401 response, raising an unhandled HTTPError that surfaces as a 500 to the caller. Unlike the legacy AccountConfigView.dispatch (which shares this weakness), this new API-driven path has no intermediary error handling, so the raw exception propagates directly to the API endpoint. A guard or early error return before calling get_user_info would prevent the crash.
Reviewed by Cursor Bugbot for commit 12fdf4e. Configure here.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-vsts-add-api-driven-integration-setup
branch
from
12fdf4e to
8322207
Compare
wedamija
approved these changes
Apr 15, 2026
| def get_serializer_cls(self) -> type: | ||
| return VstsAccountSelectionSerializer | ||
|
|
||
| def get_step_data(self, pipeline: IntegrationPipeline, request: HttpRequest) -> dict[str, Any]: |
Member
There was a problem hiding this comment.
It could be nice to return a typed dict here since we know exactly what fields we're returning
Member
Author
There was a problem hiding this comment.
Ah yeah this should be typed better
Add API-driven setup steps for the Azure DevOps (VSTS) integration so it can use the pipeline API instead of the legacy server-rendered flow. Use the shared OAuth API step with the VSTS new identity provider and add a dedicated account selection step for choosing the Azure DevOps organization. Refs [VDY-43: Azure DevOps (VSTS): API-driven integration setup](https://linear.app/getsentry/issue/VDY-43/azure-devops-vsts-api-driven-integration-setup)
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-vsts-add-api-driven-integration-setup
branch
from
8322207 to
9a68ff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add API-driven setup steps for the Azure DevOps (VSTS) integration so it
can use the pipeline API instead of the legacy server-rendered flow.
Use the shared OAuth API step with the VSTS new identity provider and
add a dedicated account selection step for choosing the Azure DevOps
organization.
Refs VDY-43: Azure DevOps (VSTS): API-driven integration setup